Skip to content

Remove schedule_update and schedule_update_any from prelude #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

Craig-Macomber
Copy link
Contributor

@Craig-Macomber Craig-Macomber commented May 16, 2025

I proposed this change in #4114 (comment) to reduce emphasis on schedule_update_any. Feel free to close if undesired.

If merged, migration guide should include a note directing people to import from dioxus::dioxus_core instead of dioxus::prelude or migrate to a different API.

@Craig-Macomber Craig-Macomber requested a review from a team as a code owner May 16, 2025 06:38
@ealmloff ealmloff added core relating to the core implementation of the virtualdom breaking This is a breaking change labels May 16, 2025
@jkelleyrtp
Copy link
Member

jkelleyrtp commented May 31, 2025

This is fine - there's a many number of things I want to move out of the prelude into dioxus::core and this won't be the only thing, but it's fine for this to be its own PR for now.

If you're interested in following it up, maybe create a new issue detailing which items don't make sense in the prelude and then a follow up PR pulling them out?

@jkelleyrtp jkelleyrtp merged commit 49e44f5 into DioxusLabs:main May 31, 2025
15 of 17 checks passed
@Craig-Macomber Craig-Macomber deleted the less_update branch May 31, 2025 23:24
@Craig-Macomber
Copy link
Contributor Author

If you're interested in following it up, maybe create a new issue detailing which items don't make sense in the prelude and then a follow up PR pulling them out?

I've only used a very small part of the API surface so I'm probably not the right person for that.

AnteDeliria pushed a commit to AnteDeliria/dioxus that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This is a breaking change core relating to the core implementation of the virtualdom
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants